Skip to content

Conversation

@janisz
Copy link
Contributor

@janisz janisz commented Jan 21, 2026

Description

Improves tools description to make e2e tests pass and change wording of affected to detected (see #26 (comment)).
Tests are in a separated PR:

Signed-off-by: Tomasz Janiszewski <tomek@redhat.com>
@janisz janisz requested a review from mtodor January 21, 2026 11:53
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.07%. Comparing base (df15807) to head (ee884dd).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #29      +/-   ##
==========================================
+ Coverage   77.58%   78.07%   +0.48%     
==========================================
  Files          26       26              
  Lines        1120     1145      +25     
==========================================
+ Hits          869      894      +25     
  Misses        216      216              
  Partials       35       35              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mtodor mtodor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Really nice work!

Let's get this in before evaluation PR.

janisz and others added 2 commits January 22, 2026 15:34
Co-authored-by: Mladen Todorovic <mtodor@gmail.com>
Addresses remaining PR review comments:
- Fix spacing in deployments.go description
- Replace WHEN TO USE/WHEN NOT TO USE with numbered USAGE PATTERNS format in nodes.go
- Remove misleading guidance that suggested not using tools for specific cluster queries
- Ensure consistent formatting across all three CVE vulnerability tools

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@janisz janisz requested a review from mtodor January 23, 2026 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants