strut desktop: refuse quarantined downloads, list every binary to sign - #1668
Merged
Conversation
Testing the release tarball as a browser download would arrive: macOS quarantines every extracted file, and dlopen of the ad-hoc-signed sherpa addon then blocks the whole Node process on a Gatekeeper prompt — strut prints its ready line and every request hangs. The `strut` wrapper now detects quarantine on the sherpa package and exits with the one-line fix (`xattr -dr com.apple.quarantine <dir>`) instead. The packaging report listed only the `.node`; the three dylibs beside it (libonnxruntime, libsherpa-onnx-c-api, libsherpa-onnx-cxx-api) must be signed and notarized in the app bundle too. It now lists .node/.dylib/.so/.dll. Docs updated for both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the release tarball the way a mac dev would receive it.
dlopenof the ad-hoc-signedsherpa-onnx.nodethen blocks the whole Node process on a "developer cannot be verified" prompt: the ready line prints, and every HTTP request hangs (reproduced:/healthtimed out, node process alive). Thestrutwrapper now detectscom.apple.quarantineon the sherpa package and exits 1 withxattr -dr com.apple.quarantine <dir>instead. Verified: quarantined → refusal message; cleared → boots withavailable: true. Acurldownload has no quarantine; a signed, notarized app bundle has no prompt..node;libonnxruntime.dylib,libsherpa-onnx-c-api.dylib,libsherpa-onnx-cxx-api.dylibsit beside it, all ad-hoc signed as shipped. Now lists.node/.dylib/.so/.dll.native-dictation-client.mdand §2.3/§5 oflocal-desktop-and-stt.mdupdated.Unrelated to the above but relevant to the release: the
strut-v0.1.0tag still points ata57bf3e6(before the yarn.lock fix in #1667), so both tag runs failed at install and the release has no assets. After this merges, re-point the tag tomain: