Skip to content

Bump to the Pedersen points-table deadlock fix (stwo-cairo #1805 / stwo-circuits #592)#371

Merged
gilbens-starkware merged 1 commit into
mainfrom
fix/pedersen-points-table-deadlock
Jun 22, 2026
Merged

Bump to the Pedersen points-table deadlock fix (stwo-cairo #1805 / stwo-circuits #592)#371
gilbens-starkware merged 1 commit into
mainfrom
fix/pedersen-points-table-deadlock

Conversation

@gilbens-starkware

@gilbens-starkware gilbens-starkware commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Bumps the privacy dependency chain onto the now-merged Pedersen points-table deadlock fix and adapts to the API changes it brought.

Dependencies

Resolves to a single stwo-cairo / stwo version across the graph:

  • stwo-cairo → a837f0ea (merged #1805 deadlock fix + #1806 exposing warm_pedersen_pp_trace).
  • stwo-circuits → 041ec610 (merged #592; pins the same stwo-cairo a837f0ea).
  • stwo stays 74951f79.

Changes

  • Warm the Pedersen points table in prepare_recursive_prover_precomputes, before gen_trace. prove_cairo_with_precompute no longer warms it itself, and PreProcessedColumn::get_data now panics if the table is read before being force-loaded.
  • Adapt verify_recursive_circuit to the ReducedHashValue / blake_qm31 renames.
  • Regenerate PRIVACY_RECURSION_CIRCUIT_PREPROCESSED_ROOT for the bumped circuit.

🤖 Generated with Claude Code


This change is Reviewable

@cursor

cursor Bot commented Jun 22, 2026

Copy link
Copy Markdown

PR Summary

Medium Risk
Changes hit proof generation and recursive verification constants/APIs; a wrong preprocessed root or hash would break verify, but scope is dependency alignment and localized call-site updates.

Overview
Bumps stwo-cairo and stwo-circuits git revisions across the workspace (including Cargo.lock) so privacy crates align with the Pedersen points-table deadlock fix and related upstream changes.

Prover: privacy_prove calls warm_pedersen_pp_trace before Cairo preprocessed trace generation so the Pedersen table is initialized before gen_trace reads it.

Verifier: Recursive verification now hashes packed outputs with circuits::blake::blake_qm31 instead of QM31::blake. Tests expect ReducedHashValue for the preprocessed Merkle root. PRIVACY_RECURSION_CIRCUIT_PREPROCESSED_ROOT in consts.rs is updated to match the new circuit/preprocessed layout.

Reviewed by Cursor Bugbot for commit 7933689. Bugbot is set up for automated code reviews on this repo. Configure here.

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ccea395. Configure here.

Comment thread .github/workflows/upload_artifacts_workflow.yml Outdated
@gilbens-starkware gilbens-starkware force-pushed the fix/pedersen-points-table-deadlock branch 3 times, most recently from 27c826b to a7010e1 Compare June 22, 2026 12:28
@codecov

codecov Bot commented Jun 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 64.29%. Comparing base (3e3450a) to head (7933689).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #371   +/-   ##
=======================================
  Coverage   64.29%   64.29%           
=======================================
  Files          39       39           
  Lines        5612     5613    +1     
=======================================
+ Hits         3608     3609    +1     
  Misses       2004     2004           
Files with missing lines Coverage Δ
crates/privacy_circuit_verify/src/lib.rs 98.55% <100.00%> (ø)
crates/privacy_prove/src/lib.rs 97.79% <100.00%> (+0.01%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilbens-starkware gilbens-starkware force-pushed the fix/pedersen-points-table-deadlock branch from a7010e1 to 384a2ed Compare June 22, 2026 12:49
Warm the Pedersen points table in the recursive precompute and regenerate the
recursion-circuit preprocessed root for the bumped deps.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gilbens-starkware gilbens-starkware force-pushed the fix/pedersen-points-table-deadlock branch from 384a2ed to 7933689 Compare June 22, 2026 13:03

@ilyalesokhin-starkware ilyalesokhin-starkware left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@ilyalesokhin-starkware reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on gilbens-starkware).

@gilbens-starkware gilbens-starkware merged commit 0b5d6af into main Jun 22, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants