Bump to the Pedersen points-table deadlock fix (stwo-cairo #1805 / stwo-circuits #592)#371
Conversation
PR SummaryMedium Risk Overview Prover: Verifier: Recursive verification now hashes packed outputs with Reviewed by Cursor Bugbot for commit 7933689. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ccea395. Configure here.
27c826b to
a7010e1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #371 +/- ##
=======================================
Coverage 64.29% 64.29%
=======================================
Files 39 39
Lines 5612 5613 +1
=======================================
+ Hits 3608 3609 +1
Misses 2004 2004
🚀 New features to boost your workflow:
|
a7010e1 to
384a2ed
Compare
Warm the Pedersen points table in the recursive precompute and regenerate the recursion-circuit preprocessed root for the bumped deps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
384a2ed to
7933689
Compare
ilyalesokhin-starkware
left a comment
There was a problem hiding this comment.
@ilyalesokhin-starkware reviewed 9 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on gilbens-starkware).

Bumps the privacy dependency chain onto the now-merged Pedersen points-table deadlock fix and adapts to the API changes it brought.
Dependencies
Resolves to a single stwo-cairo / stwo version across the graph:
a837f0ea(merged #1805 deadlock fix + #1806 exposingwarm_pedersen_pp_trace).041ec610(merged #592; pins the same stwo-cairoa837f0ea).74951f79.Changes
prepare_recursive_prover_precomputes, beforegen_trace.prove_cairo_with_precomputeno longer warms it itself, andPreProcessedColumn::get_datanow panics if the table is read before being force-loaded.verify_recursive_circuitto theReducedHashValue/blake_qm31renames.PRIVACY_RECURSION_CIRCUIT_PREPROCESSED_ROOTfor the bumped circuit.🤖 Generated with Claude Code
This change is