apollo_deployments: exact-equality app_configs parity test#14570
Draft
nimrod-starkware wants to merge 1 commit into
Draft
apollo_deployments: exact-equality app_configs parity test#14570nimrod-starkware wants to merge 1 commit into
nimrod-starkware wants to merge 1 commit into
Conversation
The applicative-vs-app_configs parity test tolerated integer-vs-float numeric differences (values_equal) and excluded values above jsonnet's max exact integer (exceeds_jsonnet_max_int). Empirically both were masking nothing real: the lone int/float divergence was a stale legacy float for l1_events_scraper_config.l1_block_time_seconds (canonical dump is as_secs() -> u64 12), and the only >2^53 value (revert_config.revert_up_to_and_including = u64::MAX) is a config-pointer target already excluded by non_default_paths. Align the stale fixture to its canonical u64 form and tighten the test to exact equality, removing both now-dead helpers. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
This change is |
Contributor
Author
This was referenced Jun 21, 2026
nimrod-starkware
changed the base branch from
nimrod/jsonnet/configmap-generator-optin
to
graphite-base/14570
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The applicative-vs-app_configs parity test tolerated integer-vs-float
numeric differences (values_equal) and excluded values above jsonnet's
max exact integer (exceeds_jsonnet_max_int). Empirically both were
masking nothing real: the lone int/float divergence was a stale legacy
float for l1_events_scraper_config.l1_block_time_seconds (canonical dump
is as_secs() -> u64 12), and the only >2^53 value
(revert_config.revert_up_to_and_including = u64::MAX) is a config-pointer
target already excluded by non_default_paths.
Align the stale fixture to its canonical u64 form and tighten the test
to exact equality, removing both now-dead helpers.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com