Skip to content

apollo_deployments: generator accepts ordered --overlay jsonnet layers#14584

Draft
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/node-loadable-all-layoutsfrom
nimrod/jsonnet/generator-multi-overlay
Draft

apollo_deployments: generator accepts ordered --overlay jsonnet layers#14584
nimrod-starkware wants to merge 1 commit into
nimrod/jsonnet/node-loadable-all-layoutsfrom
nimrod/jsonnet/generator-multi-overlay

Conversation

@nimrod-starkware

Copy link
Copy Markdown
Contributor

The deployment_config_generator now accepts overrides either as the existing flat
--config_file (unchanged) or as one-or-more ordered --overlay jsonnet layers
(exactly one mode). Each overlay is evaluated rooted at its own directory (so its
relative imports resolve locally, never against JSONNET_DIR) and the layers are
deep-merged in Rust (later wins) into the nested overrides fed to build().

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

The deployment_config_generator now accepts overrides either as the existing flat
--config_file (unchanged) or as one-or-more ordered --overlay jsonnet layers
(exactly one mode). Each overlay is evaluated rooted at its own directory (so its
relative imports resolve locally, never against JSONNET_DIR) and the layers are
deep-merged in Rust (later wins) into the nested overrides fed to build().

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

nimrod-starkware commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@reviewable-StarkWare

Copy link
Copy Markdown

This change is Reviewable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants