Conversation
add all the savedfilterschanges ive made so far,
Contributor
Author
|
I removed the toast from line 85-94 because it is actually saving the filter name on every keystroke and it was making a bunch of popups. The save button isnt really saving its more like closing. if someone has a better solution for that im all ears, I couldnt get a single onSubmit to work for the life of me. Other changes were, I moved the old save/delete buttons into the new menu, and changed some imports. thats like 95% of my changes open to feedback |
4 tasks
Collaborator
|
Superseded by: #7224 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the SavedFilterList changes I've made so far, there's some polish needed from people with more OCD than I have to contribute lmao. for instance the overflow menu gets easily obstructed and if your filter list isn't very long you will have to scroll down to see it. Also I bet the code could maybe be cleaned up a smidge.
Recording.2023-09-09.214356.mp4
This was made in response to Echo6ix's Feature Request
Closes #4077