Skip to content

Avoid setting WAL mode on read connections - #7189

Closed
smith113-p wants to merge 1 commit into
stashapp:developfrom
smith113-p:codex/avoid-read-journal-lock
Closed

smith113-p wants to merge 1 commit into
stashapp:developfrom
smith113-p:codex/avoid-read-journal-lock

Conversation

@smith113-p

Copy link
Copy Markdown
Contributor

Description

I have found that I often get an error message on the scenes page saying that there is a database lock. Codex has discovered that even read-only connections set WAL mode, which is a database-wide setting that is not read-only and can trigger this situation.

Hence, this PR only sets WAL mode on read-write connections.

Related Issue

Testing

go test ./pkg/sqlite

Screenshots

n/a

Checklist

  • I have read and understood the Contributing document.
  • I have read and understood the AI Usage Policy document.
  • [n/a] I have made corresponding changes to the documentation (if applicable).

AI Usage Disclosure

  • I have used AI tools to assist with this pull request, and I have disclosed the tools and how I used them below.

I have used ChatGPT (formerly known as Codex) to figure out what might be causing frequent database locks, and it has identified this specific code and it wrote the CL for me.

The AI policy says that comments must not be written by AI although the comment in this CL seems pretty clear as it is and I don't see the value in rewriting it. But let me know if this is an issue.

Additional Context

@Maista6969

Copy link
Copy Markdown
Contributor

Ask your bot if WAL is per-connection

@smith113-p

Copy link
Copy Markdown
Contributor Author

It's per-database, and because it is I have gotten more skeptical that this PR will fix anything (which is why I kept it in draft state).

Basically I am not sure that the underlying PRAGMA journal_mode will trigger the write lock if the DB is already in WAL mode.

@Gykes

Gykes commented Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Are we good to close this out?

@smith113-p smith113-p closed this Sep 8, 2026
@DogmaDragon DogmaDragon added the noncompliance Doesn't follow the template or other guidelines. label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

noncompliance Doesn't follow the template or other guidelines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants