Avoid setting WAL mode on read connections - #7189
Closed
smith113-p wants to merge 1 commit into
Closed
smith113-p wants to merge 1 commit into
smith113-p wants to merge 1 commit into
Conversation
Contributor
|
Ask your bot if WAL is per-connection |
Contributor
Author
|
It's per-database, and because it is I have gotten more skeptical that this PR will fix anything (which is why I kept it in draft state). Basically I am not sure that the underlying PRAGMA journal_mode will trigger the write lock if the DB is already in WAL mode. |
Collaborator
|
Are we good to close this out? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have found that I often get an error message on the scenes page saying that there is a database lock. Codex has discovered that even read-only connections set WAL mode, which is a database-wide setting that is not read-only and can trigger this situation.
Hence, this PR only sets WAL mode on read-write connections.
Related Issue
Testing
go test ./pkg/sqliteScreenshots
n/a
Checklist
AI Usage Disclosure
I have used ChatGPT (formerly known as Codex) to figure out what might be causing frequent database locks, and it has identified this specific code and it wrote the CL for me.
The AI policy says that comments must not be written by AI although the comment in this CL seems pretty clear as it is and I don't see the value in rewriting it. But let me know if this is an issue.
Additional Context