Skip to content

shrink links around cards refinements - #532

Open
marcalexiei wants to merge 4 commits into
stats-organization:masterfrom
marcalexiei:shrink-links
Open

shrink links around cards refinements#532
marcalexiei wants to merge 4 commits into
stats-organization:masterfrom
marcalexiei:shrink-links

Conversation

@marcalexiei

@marcalexiei marcalexiei commented Aug 28, 2026

Copy link
Copy Markdown

  • starlight-theme.css shrink-wraps .card-preview-link instead of every a:has(> img),
    so links around non-card images (the Vercel deploy button on the Deploy page) keep their prose layout.
  • The walk is now two flat passes: collect every image, then rewrite each once.
    Nothing is spliced mid-iteration, so a copy the plugin adds is never revisited.

@vercel

vercel Bot commented Aug 28, 2026

Copy link
Copy Markdown

@marcalexiei is attempting to deploy a commit to the martin-mfg's projects Team on Vercel.

A member of the Team first needs to authorize it.

@marcalexiei marcalexiei changed the title Shrink links refinements shrink links around cards refinements Aug 28, 2026
@marcalexiei
marcalexiei changed the base branch from shrink-links to master August 28, 2026 04:58
@marcalexiei marcalexiei reopened this Aug 28, 2026
@martin-mfg

Copy link
Copy Markdown
Member

so links around non-card images (the Vercel deploy button on the Deploy page) keep their prose layout.

Why do we want this? I think for the Vercel deploy button it's also an improvement if the link covers only the image itself, not the blank area to the right of it.

The only other difference I noticed is that there is now slightly less margin below linked images. Which seems fine to me. Am I missing a disadvantage here?

@marcalexiei
marcalexiei requested a review from martin-mfg August 28, 2026 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants