Skip to content

feat: add C implementation for stats/base/ndarray/dnanmeanwd - #14225

Merged
kgryte merged 5 commits into
stdlib-js:developfrom
ujjwalv01:feat-stats-base-ndarray-dnanmeanwd-c
Aug 15, 2026
Merged

feat: add C implementation for stats/base/ndarray/dnanmeanwd#14225
kgryte merged 5 commits into
stdlib-js:developfrom
ujjwalv01:feat-stats-base-ndarray-dnanmeanwd-c

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Resolves a part of #14034

Description

What is the purpose of this pull request?

This pull request:

  • adds a native C implementation for computing the arithmetic mean of a one-dimensional double-precision floating-point ndarray (dnanmeanwd), ignoring NaN values and using Welford's algorithm.
  • updates the test suite (test.js, test.main.js, test.native.js) and benchmarks to cover and utilize the new native C addon.

Related Issues

Does this pull request have any related issues?

This pull request has the following related issues:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

AI Assistance

When authoring the changes proposed in this PR, did you use any kind of AI assistance?

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

If you answered "yes" to using AI assistance, please provide a short disclosure indicating how you used AI assistance. This helps reviewers determine how much scrutiny to apply when reviewing your contribution. Example disclosures: "This PR was written primarily by Claude Code." or "I consulted ChatGPT to understand the codebase, but the proposed changes were fully authored manually by myself.".

I consulted an AI assistant to help structure and generate the test files (test.main.js, test.native.js) and benchmark files required to test the native C addon. The core logic and implementation were authored manually by myself.


@stdlib-js/reviewers

@stdlib-bot stdlib-bot added the Statistics Issue or pull request related to statistical functionality. label Aug 13, 2026
@stdlib-bot

stdlib-bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
stats/base/ndarray/dnanmeanwd $\\color{green}176/176$
$\\color{green}+0.00\\%$
$\\color{green}7/7$
$\\color{green}+0.00\\%$
$\\color{green}2/2$
$\\color{green}+0.00\\%$
$\\color{green}176/176$
$\\color{green}+0.00\\%$

The above coverage report was generated for the changes in this PR.

@ujjwalv01
ujjwalv01 marked this pull request as ready for review August 13, 2026 13:46
@ujjwalv01
ujjwalv01 requested a review from a team August 13, 2026 13:46
@stdlib-bot stdlib-bot added the Needs Review A pull request which needs code review. label Aug 13, 2026
@kgryte kgryte added Feature Issue or pull request for adding a new feature. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. review: 5 and removed Needs Review A pull request which needs code review. labels Aug 15, 2026
Comment thread lib/node_modules/@stdlib/stats/base/ndarray/dnanmeanwd/test/test.main.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
Comment thread lib/node_modules/@stdlib/stats/base/ndarray/dnanmeanwd/test/test.native.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte previously approved these changes Aug 15, 2026

@kgryte kgryte left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lib/node_modules/@stdlib/stats/base/ndarray/dnanmeanwd/test/test.main.js Outdated
Comment thread lib/node_modules/@stdlib/stats/base/ndarray/dnanmeanwd/test/test.native.js Outdated
Co-authored-by: Athan <kgryte@gmail.com>
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
kgryte merged commit f9c3112 into stdlib-js:develop Aug 15, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. review: 5 Statistics Issue or pull request related to statistical functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants