bench: fix description and update variable names in blas/base/ndarray - #14261
Open
Planeshifter wants to merge 1 commit into
Open
bench: fix description and update variable names in blas/base/ndarray#14261Planeshifter wants to merge 1 commit into
blas/base/ndarray#14261Planeshifter wants to merge 1 commit into
Conversation
Propagates fix from d0d2857 ("bench: fix description and update variable names") to sibling matrix benchmarks in `blas/base/ndarray` with the same mislabeled workload size: the benchmark factory parameter was documented as an array length while being the matrix dimension, and benchmark labels reported the dimension via `len=%d` rather than the element count via `size=%d`. Affected packages: cgemv, dgemm, dgemv, dger, dspr, dsyr, dsyr2, ggemm, ggemv, gger, gsyr, sgemm, sgemv, sger, sspr, ssyr, ssyr2. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013Z4Xtpa7cD9BHHLV96uPcg
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
developbetween 2026-08-13 and 2026-08-14 to sibling packages.Same defect propagates through the level-2/level-3
blas/base/ndarraymatrix benchmarks (cgemv, dgemm, dgemv, dger, dspr, dsyr, dsyr2, ggemm, ggemv, gger, gsyr, sgemm, sgemv, sger, sspr, ssyr, ssyr2): benchmark factories documentlenas array length when it is the matrix dimension, and labels reportlen=%drather thansize=%dperdocs/contributing/benchmark_names.md. RenamelentoNin eachbenchmark/benchmark.js, correct the JSDoc to "number of elements along each dimension", and switch labels tosize=%dusingN*Nfor dense routines or( N * ( N+1 ) ) / 2for packed routines (dspr, sspr), bringing these ndarray variants in line with their already-migratedblas/base/*counterparts.Source commit: d0d285717b (
bench: fix description and update variable names). Target packages:@stdlib/blas/base/ndarray/cgemv@stdlib/blas/base/ndarray/dgemm@stdlib/blas/base/ndarray/dgemv@stdlib/blas/base/ndarray/dger@stdlib/blas/base/ndarray/dspr@stdlib/blas/base/ndarray/dsyr@stdlib/blas/base/ndarray/dsyr2@stdlib/blas/base/ndarray/ggemm@stdlib/blas/base/ndarray/ggemv@stdlib/blas/base/ndarray/gger@stdlib/blas/base/ndarray/gsyr@stdlib/blas/base/ndarray/sgemm@stdlib/blas/base/ndarray/sgemv@stdlib/blas/base/ndarray/sger@stdlib/blas/base/ndarray/sspr@stdlib/blas/base/ndarray/ssyr@stdlib/blas/base/ndarray/ssyr2Related Issues
No.
Questions
No.
Other
Validation: candidate sites were enumerated by searching all benchmark files for
len=%dlabels co-occurring with N×N matrix construction; two independent validation passes confirmed the defect at each site by reading each original file in full, an adaptation pass verified the per-site size expressions (dense vs. packed storage, complex interleaved buffers), and a style pass checked declaration ordering, label naming perdocs/contributing/benchmark_names.md, and JSDoc wording against the source commit and already-migratedblas/base/*counterparts. Deliberately excluded:benchmark.length.jsfiles for cartesian-product-style packages (label semantics differ), level-1 vector routines (wherelen=%dis correct), and BLAS-levelblas/base/*gemm/*gerfiles (already migrated tosize=%d).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was written by Claude Code as part of an automated fix-propagation routine: it applies the fix from commit d0d285717b to sibling packages, with each target site validated by independent review passes before inclusion.
Generated by Claude Code