fix(home): stack hero content on mobile - #115
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
nibzard
marked this pull request as ready for review
August 3, 2026 09:47
nibzard
added a commit
that referenced
this pull request
Aug 4, 2026
The assertion matched the whole class attribute as one string, so #115 adding `self-center sm:self-auto` for mobile stacking broke it even though the invariant it guards still held. The logo must keep `shrink-0` so the hero's flex row cannot squash it; responsive alignment classes around it are free to change. Verified the assertion still fails when shrink-0 is actually removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
The longer canonical identity sentence introduced in #113 made the fixed 188px logo and copy compete
for the same narrow mobile row. Because the row was bottom-aligned, the logo was pushed down while
the text wrapped into a very narrow column.
Impact
The homepage hero is readable at phone widths, the logo keeps a stable position, and the
answer-engine identity copy remains visible and unchanged.
Validation
bunx biome check 'app/(home)/_pages/page.en.tsx'bun run typecheckbun run checkalso ran, but the repository baseline currently reports missing trailing newlinesin
scripts/seo/pulse/snapshots/tech-2026-07.jsonandscripts/seo/pulse/snapshots/volumes-2026-07.json; this PR does not touch those files.