Add a Grok visor critter to the menu bar

[sm0keyyy]

Summary

• give Grok a provider-specific visor creature in the menu-bar quota icon
• preserve CodexBar's existing capsule-bar grammar and Hide Critters behavior
• add native-grid, decoration-membership, and architecture-gate coverage

Why

Grok currently uses undifferentiated plain quota bars while the other major providers have recognizable critter treatments. The twin antennae and single visor create a distinct Grok silhouette without borrowing Codex eyes, Claude limbs, Gemini sparkles, Factory gears, or Warp fox eyes.

Validation

• make test — 891 selections across 75 groups passed
• make check
• native 18 pt normal and Hide Critters renders reviewed independently

Screenshot

[clawsweeper]

🦞👀
ClawSweeper picked this up.

Pull request received. I will update this pull request when review starts.

[clawsweeper]

Codex review: needs maintainer review before merge. Reviewed August 18, 2026, 9:25 PM ET / August 19, 2026, 01:25 UTC.

ClawSweeper review

What this changes

Adds a Grok visor-and-antennae decoration to the menu-bar quota icon, wires it through provider presentation metadata, and extends renderer policy tests.

Merge readiness

⚠️ Ready for maintainer review - 3 items remain

Keep open for a maintainer visual-direction decision. Current main still renders Grok without a decoration; this focused, tested PR adds a distinct default silhouette and has relevant screenshot proof.

Priority: P3
Reviewed head: fab522a78695e4b94bc2c6ab71897d4638974474
Owner decision: Required. See Decision needed.

Review scores

Measure	Result	What it means
Overall readiness	🐚 platinum hermit (4/6)	A focused patch with direct visual proof and targeted tests; only the intentional product-style decision remains.
Proof confidence	🦞 diamond lobster (5/6) ✨ media proof bonus	Sufficient (screenshot): The PR body provides a directly relevant native 18-point screenshot showing the normal Grok render and the Hide Critters render after the change.
Patch quality	🐚 platinum hermit (4/6)	No actionable review findings were identified.

Verification

Check	Result	Evidence
Real behavior	Verified	Sufficient (screenshot): The PR body provides a directly relevant native 18-point screenshot showing the normal Grok render and the Hide Critters render after the change.
Evidence reviewed	5 items	Current-main gap: Current main has Grok presentation labels but no Grok icon decoration, and its renderer only selects the existing decoration set; the requested visual behavior is not already implemented. Focused implementation: The PR draws the visor and antennae and passes the Grok decoration through every ordinary quota/credits layout while Hide Critters clears all decorations first. Coverage: The branch adds pixel-grid coverage plus existing decoration-membership, Hide Critters, and architecture-gate coverage for Grok.
Findings	None	None.
Security	None	None.

Live Verification

Command: swift test --filter 'icon renderer grok visor and antennae use expected grid positions'

Result: FAIL (failed) — execution before step 1 run: sh -lc pnpm install --ignore-scripts --frozen-lockfile failed: ! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-11.22.0.tgz

sh -lc pnpm install --ignore-scripts --frozen-lockfile failed: ! Corepack is about to download https://registry.npmjs.org/pnpm/-/pnpm-11.22.0.tgz

Assertions:

• FAIL expect_output: 1 test passed

How this fits together

CodexBar converts provider usage snapshots into compact menu-bar icons. Provider presentation metadata selects an optional decoration, which the icon renderer draws unless the user enables Hide Critters.

flowchart LR
A[Provider usage snapshot] --> B[Provider presentation metadata]
B --> C[Icon decoration selection]
C --> D[Menu-bar icon renderer]
D --> E[Visible quota icon]
F[Hide Critters preference] --> D

Loading

Decision needed

Question	Recommendation
Should Grok’s default quota icon adopt the proposed visor-and-antennae critter treatment?	Adopt the Grok critter: Accept the screenshot-backed visor treatment as Grok’s default decoration while preserving the existing Hide Critters preference.

Why: The implementation is bounded and follows the established decoration mechanism, but choosing a provider’s default visual identity is product taste rather than a mechanically provable correctness question.

Before merge

• Resolve merge risk (P1) - Merging changes the default 18-point menu-bar silhouette for existing Grok users; tests and a screenshot cannot decide whether that visual language belongs in the product.
• Complete next step (P2) - A maintainer must choose the default Grok visual language; no mechanical repair or additional contributor proof is indicated.

Agent review details

Security

None.

Review metrics

Metric	Value	Why it matters
Implementation and test delta	production +57/-7, tests +38/-5 across 8 files	The visual feature is localized and has focused renderer, preference, and architecture-policy coverage.

Merge-risk options

Maintainer options:

1. Confirm the visual direction (recommended)
   Merge after the product owner explicitly accepts the new default Grok silhouette for existing users.
2. Retain plain bars
   Close the PR if the product direction is to keep Grok visually undecorated by default.

Technical review

Best possible solution:

Adopt the visor only if the product owner confirms it belongs with the existing provider-specific critter language, while retaining Hide Critters as the plain-bars escape hatch.

Do we have a high-confidence way to reproduce the issue?

Not applicable: this PR proposes a visual feature, not a defect with a failing reproduction path.

Is this the best way to solve the issue?

Yes technically: it uses the existing provider-presentation decoration path and preserves Hide Critters; acceptance still depends on maintainer visual-direction judgment.

AGENTS.md: found and applied where relevant.

Codex review notes: model internal, reasoning high; reviewed against a32989c750e6.

Labels

Label justifications:

• P3: This is a low-risk visual enhancement rather than a reliability or provider-data regression.
• merge-risk: 🚨 other: The PR intentionally changes the default menu-bar icon appearance for existing Grok users, a product-fit choice CI cannot settle.
• rating: 🐚 platinum hermit: Overall readiness is 🐚 platinum hermit; proof is 🦞 diamond lobster and patch quality is 🐚 platinum hermit.
• status: 👀 ready for maintainer look: ClawSweeper has no concrete contributor-facing blocker left for this PR. Sufficient (screenshot): The PR body provides a directly relevant native 18-point screenshot showing the normal Grok render and the Hide Critters render after the change.
• proof: sufficient: Contributor real behavior proof is sufficient. The PR body provides a directly relevant native 18-point screenshot showing the normal Grok render and the Hide Critters render after the change.
• proof: 📸 screenshot: Contributor real behavior proof includes screenshot evidence. The PR body provides a directly relevant native 18-point screenshot showing the normal Grok render and the Hide Critters render after the change.

Evidence

What I checked:

• Current-main gap: Current main has Grok presentation labels but no Grok icon decoration, and its renderer only selects the existing decoration set; the requested visual behavior is not already implemented. (Sources/CodexBarCore/Providers/Grok/GrokProviderDescriptor.swift:101, a32989c750e6)
• Focused implementation: The PR draws the visor and antennae and passes the Grok decoration through every ordinary quota/credits layout while Hide Critters clears all decorations first. (Sources/CodexBar/IconRenderer.swift:639, fab522a78695)
• Coverage: The branch adds pixel-grid coverage plus existing decoration-membership, Hide Critters, and architecture-gate coverage for Grok. (Tests/CodexBarTests/CodexbarTests.swift:852, fab522a78695)
• Feature provenance: Current renderer and Grok presentation lines trace to the v0.53.0 baseline commit, making its author the strongest routing candidate for the default visual-language decision. (Sources/CodexBar/IconRenderer.swift:704, 5a2a70458d95)
• Release baseline: The current Grok plain-bar baseline is in released v0.53.0; main is ahead of that release and still lacks this proposed decoration. (version.env:1, a32989c750e6)

Likely related people:

• steipete: Blame attributes the current decoration-selection boundary and Grok presentation baseline to this v0.53.0 commit. (role: current renderer and Grok presentation author; confidence: high; commits: 5a2a70458d95; files: Sources/CodexBar/IconRenderer.swift, Sources/CodexBarCore/Providers/Grok/GrokProviderDescriptor.swift)

Rating scale

Score	Internal tier	Crab rank	Meaning
6/6	S	🦀 challenger crab	Exceptional readiness
5/6	A	🦞 diamond lobster	Very strong readiness
4/6	B	🐚 platinum hermit	Good normal PR; ordinary maintainer review
3/6	C	🦐 gold shrimp	Useful, but confidence is limited
2/6	D	🦪 silver shellfish	Proof or implementation needs work
1/6	F	🧂 unranked krab	Not merge-ready
N/A	NA	🌊 off-meta tidepool	Rating does not apply

Overall follows the weaker of proof and patch quality.
Shiny media proof means a screenshot, video, or linked artifact directly shows the changed behavior. Runtime, network, CSP, and security claims still need visible diagnostics.

Workflow

• ClawSweeper keeps one durable marker-backed review comment per issue or PR.
• Re-runs edit this comment so the latest verdict, findings, and automation markers stay together instead of adding duplicate bot comments.
• A fresh review can be triggered by eligible @clawsweeper re-review comments, exact-item GitHub events, scheduled/background review runs, or manual workflow dispatch.
• PR/issue authors and users with repository write access can comment @clawsweeper re-review or @clawsweeper re-run on an open PR or issue to request a fresh review only.
• Maintainers can also comment @clawsweeper review to request a fresh review only.
• Fresh-review commands do not start repair, autofix, rebase, CI repair, or automerge.
• Maintainer-only repair and merge flows require explicit commands such as @clawsweeper autofix, @clawsweeper automerge, @clawsweeper fix ci, or @clawsweeper address review.
• Maintainers can comment @clawsweeper explain to ask for more context, or @clawsweeper stop to stop active automation.

History

Review history (3 earlier review cycles)

• reviewed 2026-08-18T02:53:18.965Z sha fab522a :: needs real behavior proof before merge. :: none
• reviewed 2026-08-18T02:58:04.622Z sha fab522a :: needs maintainer review before merge. :: none
• reviewed 2026-08-18T03:05:42.240Z sha fab522a :: needs maintainer review before merge. :: none