fix(cli): search-dir and html flag behaviour#16
Open
swarit-stepsecurity wants to merge 1 commit intostep-security:mainfrom
Open
fix(cli): search-dir and html flag behaviour#16swarit-stepsecurity wants to merge 1 commit intostep-security:mainfrom
swarit-stepsecurity wants to merge 1 commit intostep-security:mainfrom
Conversation
Signed-off-by: Swarit Pandey <swarit.pandey@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
cli.go— two fixes, two helpers:--search-dirsgreedy loop now stops at flags (- prefix) and known commands, not just -- prefix--htmlnow rejects flag-looking arguments as the file pathlooksLikeFlag(s)— matches any - prefixed argisCommand(s)— matches known command names (install, uninstall, send-telemetry, configure, version, help)Type of change
Testing
./stepsecurity-dev-machine-guard --verbose./stepsecurity-dev-machine-guard --json | python3 -m json.toolmake lintmake testRelated Issues