database: close pgxpool on db.Close and apply pool defaults to pgxpool - #4
Open
adamdecaf wants to merge 1 commit into
Conversation
stdlib.OpenDBFromPool does not close the underlying pool when *sql.DB is closed, leaking connections and the health-check goroutine. Wrap the pool connector with io.Closer so db.Close() shuts down the pgxpool and AlloyDB dialer. Also stop applying ConnectionsConfig via database/sql setters for Postgres: those do not configure pgxpool, and SetMaxIdleConns(n>0) breaks OpenDBFromPool. Map resolved defaults onto pgxpool instead so unset MaxOpen does not silently fall back to max(4, NumCPU()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up fixes for moov-io#490.
*sql.DBis closedConnectionsConfigdefaults on pgxpool, notdatabase/sqlSee commit message for details.