Skip to content

(closes #2429) Make all structure constructors and functions with unknown declarations Calls#3354

Merged
arporter merged 15 commits intomasterfrom
2429_all_functions_and_constructors_are_calls
Mar 3, 2026
Merged

(closes #2429) Make all structure constructors and functions with unknown declarations Calls#3354
arporter merged 15 commits intomasterfrom
2429_all_functions_and_constructors_are_calls

Conversation

@sergisiso
Copy link
Collaborator

@sergisiso sergisiso commented Feb 26, 2026

In turn this simplifies the Invoke/Kernel uplifting, because we don't have to deal with the case with Codeblocks anymore.

@codecov
Copy link

codecov bot commented Feb 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (974f435) to head (895ff30).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3354      +/-   ##
==========================================
- Coverage   99.95%   99.95%   -0.01%     
==========================================
  Files         386      386              
  Lines       54215    54190      -25     
==========================================
- Hits        54193    54168      -25     
  Misses         22       22              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sergisiso
Copy link
Collaborator Author

@arporter @LonelyCat124 @hiker This is ready for a first review.

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, impressive simplification :-)
I just have a question about one of the changes to a test.

@sergisiso
Copy link
Collaborator Author

@arporter See response above

Copy link
Member

@arporter arporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying.
Will re-run the ITs as a few things have gone on master since the last time. If they are OK then will proceed to merge.

@arporter
Copy link
Member

arporter commented Mar 3, 2026

Link-check failure is a timeout on the NVIDIA website. Link works for me though.

@arporter
Copy link
Member

arporter commented Mar 3, 2026

ITs were all green.

@arporter arporter merged commit 9ed1f1c into master Mar 3, 2026
13 of 15 checks passed
@arporter arporter deleted the 2429_all_functions_and_constructors_are_calls branch March 3, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants