Conversation
…and_constructors_are_calls
…and_constructors_are_calls
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3354 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 386 386
Lines 54215 54190 -25
==========================================
- Hits 54193 54168 -25
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…mation' into 2429_all_functions_and_constructors_are_calls
…and_constructors_are_calls
|
@arporter @LonelyCat124 @hiker This is ready for a first review. |
arporter
left a comment
There was a problem hiding this comment.
Nice, impressive simplification :-)
I just have a question about one of the changes to a test.
|
@arporter See response above |
arporter
left a comment
There was a problem hiding this comment.
Thanks for clarifying.
Will re-run the ITs as a few things have gone on master since the last time. If they are OK then will proceed to merge.
|
Link-check failure is a timeout on the NVIDIA website. Link works for me though. |
|
ITs were all green. |
In turn this simplifies the Invoke/Kernel uplifting, because we don't have to deal with the case with Codeblocks anymore.