(Towards #2668) Conversion of some more transformations#3365
Open
LonelyCat124 wants to merge 7 commits intomasterfrom
Open
(Towards #2668) Conversion of some more transformations#3365LonelyCat124 wants to merge 7 commits intomasterfrom
LonelyCat124 wants to merge 7 commits intomasterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3365 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 387 387
Lines 54187 54275 +88
=======================================
+ Hits 54165 54253 +88
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@sergisiso @arporter These are ready for a first look. Many of them have little to no noticable changes, but there are a few that required more work to keep behaviour, and required some changes in the domain inheriting transformations because they broke inheriting transformations via new keyword options otherwise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doing some more conversion of transformations to the new style so we can kill off options one day. Continuing to work on this today a bit more and then we can look at merging the changes. Some have almost nothing done to them, others do have options that needed updating.
I didn't update LFricLoopFuseTrans to use the new methodology as it seemed more complex to rewrite (due to it updating a local dict and things), I just did the minimum to make tests work.