Skip to content

(Towards #2668) Conversion of some more transformations#3365

Open
LonelyCat124 wants to merge 7 commits intomasterfrom
transformation_options
Open

(Towards #2668) Conversion of some more transformations#3365
LonelyCat124 wants to merge 7 commits intomasterfrom
transformation_options

Conversation

@LonelyCat124
Copy link
Collaborator

@LonelyCat124 LonelyCat124 commented Mar 10, 2026

Doing some more conversion of transformations to the new style so we can kill off options one day. Continuing to work on this today a bit more and then we can look at merging the changes. Some have almost nothing done to them, others do have options that needed updating.

I didn't update LFricLoopFuseTrans to use the new methodology as it seemed more complex to rewrite (due to it updating a local dict and things), I just did the minimum to make tests work.

@codecov
Copy link

codecov bot commented Mar 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.95%. Comparing base (eb35caa) to head (44c290e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3365   +/-   ##
=======================================
  Coverage   99.95%   99.95%           
=======================================
  Files         387      387           
  Lines       54187    54275   +88     
=======================================
+ Hits        54165    54253   +88     
  Misses         22       22           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@LonelyCat124 LonelyCat124 marked this pull request as ready for review March 10, 2026 17:31
@LonelyCat124
Copy link
Collaborator Author

@sergisiso @arporter These are ready for a first look. Many of them have little to no noticable changes, but there are a few that required more work to keep behaviour, and required some changes in the domain inheriting transformations because they broke inheriting transformations via new keyword options otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant