(closes #3369) Add nc file comparisons in the NEMOv5 integration tests#3372
Merged
(closes #3369) Add nc file comparisons in the NEMOv5 integration tests#3372
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3372 +/- ##
=======================================
Coverage 99.95% 99.95%
=======================================
Files 387 387
Lines 54187 54187
=======================================
Hits 54165 54165
Misses 22 22 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@arporter @LonelyCat124 This is ready for review, it completed the NEMOv5 integration test (I just requested a re-run because it has a modification to passthrough which is only executed on re-run) |
arporter
approved these changes
Mar 16, 2026
Member
arporter
left a comment
arporter
left a comment
There was a problem hiding this comment.
All good, thanks for adding this check Sergi (and Aidan for opening the issue).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.