Skip to content

fix(telemetry): added latest semantic conventions as span attributes for langfuse #1768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
poshinchen merged 1 commit into from
Feb 27, 2026
Merged

fix(telemetry): added latest semantic conventions as span attributes for langfuse #1768

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 34 additions & 21 deletions src/strands/telemetry/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,17 @@ def _parse_semconv_opt_in(self) -> set[str]:
opt_in_env = os.getenv("OTEL_SEMCONV_STABILITY_OPT_IN", "")
return {value.strip() for value in opt_in_env.split(",")}

@property
def is_langfuse(self) -> bool:
"""Check if Langfuse is configured as the OTLP endpoint.

Returns:
True if Langfuse is the OTLP endpoint, False otherwise.
"""
return "langfuse" in os.getenv("OTEL_EXPORTER_OTLP_ENDPOINT", "") or "langfuse" in os.getenv(
"OTEL_EXPORTER_OTLP_TRACES_ENDPOINT", ""
)

def _start_span(
self,
span_name: str,
Expand Down Expand Up @@ -142,23 +153,10 @@ def _start_span(

# Add all provided attributes
if attributes:
self._set_attributes(span, attributes)
span.set_attributes(attributes)

return span

def _set_attributes(self, span: Span, attributes: dict[str, AttributeValue]) -> None:
"""Set attributes on a span, handling different value types appropriately.

Args:
span: The span to set attributes on
attributes: Dictionary of attributes to set
"""
if not span:
return

for key, value in attributes.items():
span.set_attribute(key, value)

def _add_optional_usage_and_metrics_attributes(
self, attributes: dict[str, AttributeValue], usage: Usage, metrics: Metrics
) -> None:
Expand Down Expand Up @@ -203,7 +201,7 @@ def _end_span(

# Add any additional attributes
if attributes:
self._set_attributes(span, attributes)
span.set_attributes(attributes)

# Handle error if present
if error:
Expand Down Expand Up @@ -236,17 +234,24 @@ def end_span_with_error(self, span: Span, error_message: str, exception: Excepti
error = exception or Exception(error_message)
self._end_span(span, error=error)

def _add_event(self, span: Span | None, event_name: str, event_attributes: Attributes) -> None:
def _add_event(
self, span: Span | None, event_name: str, event_attributes: Attributes, to_span_attributes: bool = False
) -> None:
"""Add an event with attributes to a span.

Args:
span: The span to add the event to
event_name: Name of the event
event_attributes: Dictionary of attributes to set on the event
to_span_attributes: Add the attributes to span attributes
"""
if not span:
return

# Add to span attribute since some backend can't read the events
if to_span_attributes and event_attributes:
span.set_attributes(event_attributes)

span.add_event(event_name, attributes=event_attributes)

def _get_event_name_for_message(self, message: Message) -> str:
Expand Down Expand Up @@ -358,6 +363,7 @@ def end_model_invoke_span(
]
),
},
to_span_attributes=self.is_langfuse,
)
else:
self._add_event(
Expand All @@ -366,7 +372,7 @@ def end_model_invoke_span(
event_attributes={"finish_reason": str(stop_reason), "message": serialize(message["content"])},
)

self._set_attributes(span, attributes)
span.set_attributes(attributes)

def start_tool_call_span(
self,
Expand Down Expand Up @@ -423,6 +429,7 @@ def start_tool_call_span(
]
)
},
to_span_attributes=self.is_langfuse,
)
else:
self._add_event(
Expand Down Expand Up @@ -476,6 +483,7 @@ def end_tool_call_span(self, span: Span, tool_result: ToolResult | None, error:
]
)
},
to_span_attributes=self.is_langfuse,
)
else:
self._add_event(
Expand Down Expand Up @@ -572,6 +580,7 @@ def end_event_loop_cycle_span(
]
)
},
to_span_attributes=self.is_langfuse,
)
else:
self._add_event(span, "gen_ai.choice", event_attributes=event_attributes)
Expand Down Expand Up @@ -666,6 +675,7 @@ def end_agent_span(
]
)
},
to_span_attributes=self.is_langfuse,
)
else:
self._add_event(
Expand All @@ -675,9 +685,7 @@ def end_agent_span(
)

if hasattr(response, "metrics") and hasattr(response.metrics, "accumulated_usage"):
if "langfuse" in os.getenv("OTEL_EXPORTER_OTLP_ENDPOINT", "") or "langfuse" in os.getenv(
"OTEL_EXPORTER_OTLP_TRACES_ENDPOINT", ""
):
if self.is_langfuse:
attributes.update({"langfuse.observation.type": "span"})
accumulated_usage = response.metrics.accumulated_usage
attributes.update(
Expand Down Expand Up @@ -736,6 +744,7 @@ def start_multiagent_span(
span,
"gen_ai.client.inference.operation.details",
{"gen_ai.input.messages": serialize([{"role": "user", "parts": parts}])},
to_span_attributes=self.is_langfuse,
)
else:
self._add_event(
Expand Down Expand Up @@ -767,6 +776,7 @@ def end_swarm_span(
]
)
},
to_span_attributes=self.is_langfuse,
)
else:
self._add_event(
Expand Down Expand Up @@ -816,7 +826,10 @@ def _add_event_messages(self, span: Span, messages: Messages) -> None:
{"role": message["role"], "parts": self._map_content_blocks_to_otel_parts(message["content"])}
)
self._add_event(
span, "gen_ai.client.inference.operation.details", {"gen_ai.input.messages": serialize(input_messages)}
span,
"gen_ai.client.inference.operation.details",
{"gen_ai.input.messages": serialize(input_messages)},
to_span_attributes=self.is_langfuse,
)
else:
for message in messages:
Expand Down
Loading
Loading