Open
Conversation
vivekr123
force-pushed
the
enable-solver-choice-cvc5
branch
3 times, most recently
from
a8af244 to
66aa8ea
Compare
shigoel
requested changes
Feb 6, 2026
Contributor
shigoel
left a comment
shigoel
left a comment
There was a problem hiding this comment.
Thanks, @vivekr123! Left a couple of comments.
Strata/Languages/Core/Options.lean
Outdated
| solverTimeout := 10, | ||
| outputSarif := false | ||
| outputSarif := false, | ||
| solver := "z3" |
Contributor
There was a problem hiding this comment.
I'd rather have the default be cvc5.
Strata/DL/SMT/Solver.lean
Outdated
| } | ||
| return ⟨IO.FS.Stream.ofHandle proc.stdin, IO.FS.Stream.ofHandle proc.stdout⟩ | ||
| catch e => | ||
| let suggestion := if path.endsWith "z3" || path == "z3" then " Try running with '--solver cvc5' to use cvc5 instead (ensure cvc5 is on your PATH)." else "" |
Contributor
There was a problem hiding this comment.
Let's remove the z3-specific check, and mention only cvc5 in the suggestion.
Author
There was a problem hiding this comment.
Is the new suggestion closer to what we're looking for?
Contributor
|
CC: @abdoo8080 @ChengZ3 |
auto-merge was automatically disabled
February 6, 2026 23:16
Head branch was pushed to by a user without write access
vivekr123
force-pushed
the
enable-solver-choice-cvc5
branch
2 times, most recently
from
29ed41a to
d24c15d
Compare
vivekr123
force-pushed
the
enable-solver-choice-cvc5
branch
from
d24c15d to
3255141
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggest cvc5 when solver not found