fix(memfs): align runtime dependencies with published entry points - #1287
Open
xianjianlf2 wants to merge 1 commit into
Open
fix(memfs): align runtime dependencies with published entry points#1287xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The published
memfs/lib/fsa-to-nodeentry point imports@jsonjoy.com/fs-fsa-to-node, but memfs does not declare that runtime dependency. A production-only installation of the released memfs 4.71.0 fails to import the entry point withMODULE_NOT_FOUND. Declare the adapter alongside the other workspace runtime packages.Remove the unused direct
@jsonjoy.com/json-packand@jsonjoy.com/utildependencies and refresh the lockfile, addressing #1254. memfs's source does not import those packages; their actual consumers retain their own declarations. The older major versions still appear transitively through the FSA-to-Node adapter, so this does not claim to eliminate every old version from the tree.Validation:
require('memfs/lib/fsa-to-node')fails in an isolated production-only installation of published memfs 4.71.0.--omit=dev --ignore-scripts. The main filesystem API and all three adapter entry points (fsa,node-to-fsa,fsa-to-node) load successfully, and file read/write smoke checks pass.yarn testpassed (1,438 tests, 18 existing skips, 14 snapshots).AI-assisted implementation and validation.