add ability to filter modules from lock file#26
Open
ngbinh wants to merge 2 commits intostringbean:mainfrom
Open
add ability to filter modules from lock file#26ngbinh wants to merge 2 commits intostringbean:mainfrom
ngbinh wants to merge 2 commits intostringbean:mainfrom
Conversation
This is necessary for multi module projects where the internal modules version keeps changing
to allow projects an easier way to overwrite their values
stringbean
requested changes
Jul 1, 2021
Owner
stringbean
left a comment
stringbean
left a comment
There was a problem hiding this comment.
Looks good. Can you add some scripted tests for this and then I can get it merged in?
| val dependencyLockFile = settingKey[File]("lockfile to generate") | ||
| val dependencyLockWrite = taskKey[File]("write dependencies to lockfile") | ||
| val dependencyLockRead = taskKey[Option[DependencyLockFile]]("read dependencies from lockfile") | ||
| val dependencyLockExclusion = settingKey[ModuleFilter]("lockfile module exclusion filter") |
Owner
There was a problem hiding this comment.
Can you change this to:
Suggested change
| val dependencyLockExclusion = settingKey[ModuleFilter]("lockfile module exclusion filter") | |
| val dependencyLockModuleFilter = settingKey[ModuleFilter]("exclusion filter for dependencies") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is necessary for multi-module projects where the internal modules
version keeps changing based on the git hash.