fix: attach MPP credentials with mppx - #324
Merged
stevekaliski-stripe merged 1 commit intoSep 14, 2026
Merged
stevekaliski-stripe merged 1 commit into
stevekaliski-stripe merged 1 commit into
Conversation
brendanjryan
commented
Sep 14, 2026
| return Mppx.create({ | ||
| methods: [stripeCharge, stripeSession], | ||
| polyfill: false, | ||
| transport: Transport.from<RequestInit, Response>({ |
Contributor
Author
There was a problem hiding this comment.
we can remove this custom transport now that we have preparePayment
stevekaliski-stripe
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
MPP challenges can select a credential header other than
Authorization. The CLI should rely on mppx transport behavior instead of duplicating attachment logic.Summary
Key design considerations