Skip to content

fix: reject changed MPP challenges after approval - #325

Merged
stevekaliski-stripe merged 3 commits into
stripe:mainfrom
brendanjryan:brendanjryan/verify-refreshed-mpp-challenge
Sep 14, 2026
Merged

stevekaliski-stripe merged 3 commits into
stripe:mainfrom
brendanjryan:brendanjryan/verify-refreshed-mpp-challenge

Conversation

@brendanjryan

Copy link
Copy Markdown
Contributor

Motivation

The CLI refreshes an MPP challenge after user approval. A refreshed challenge must not change the terms that the user approved.

Summary

  • Retain the approved challenge through the spend request flow
  • Compare refreshed challenge terms before attaching the approved credential
  • Reject changes to payment, merchant, or intent fields

Key design considerations

  • Allow challenge identifiers and expirations to refresh
  • Compare the canonical challenge representation for all other fields
  • Leave direct payment with an existing spend request unchanged because no original challenge is available

@brendanjryan
brendanjryan requested a review from a team as a code owner September 14, 2026 00:52
@brendanjryan
brendanjryan force-pushed the brendanjryan/verify-refreshed-mpp-challenge branch from 442a450 to 207948b Compare September 14, 2026 18:39
@stevekaliski-stripe
stevekaliski-stripe merged commit 19f566c into stripe:main Sep 14, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants