Repository navigation
Fix stale Checkout saved method selection - #14522
Merged
Merged
Conversation
jaynewstrom-stripe
force-pushed
the
fix/checkout-rebind-saved-selection
branch
2 times, most recently
from
September 14, 2026 13:59
533bf66 to
c37de40
Compare
jaynewstrom-stripe
force-pushed
the
fix/checkout-rebind-saved-selection
branch
3 times, most recently
from
October 6, 2026 17:39
d09e14d to
2878e14
Compare
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
jaynewstrom-stripe
force-pushed
the
fix/checkout-rebind-saved-selection
branch
from
October 6, 2026 19:13
2878e14 to
8b50ebf
Compare
jaynewstrom-stripe
marked this pull request as ready for review
October 6, 2026 19:59
jaynewstrom-stripe
enabled auto-merge (squash)
October 6, 2026 21:14
cttsai-stripe
approved these changes
Oct 6, 2026
cttsai-stripe
left a comment
cttsai-stripe
left a comment
Contributor
There was a problem hiding this comment.
Is this a PR that only adds tests?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Checkout updates its customer payment-method list when Payment Options is canceled, but previously only checked whether the selected method ID still existed. If that method had been edited, the parent selection retained the old object and could show stale label, billing, or network data. This matches FlowController's behavior by rebinding the selection to the updated object with the same ID.
Testing
Automated checks:
./gradlew :paymentsheet:testDebugUnitTest --tests 'com.stripe.android.checkout.CheckoutSheetLauncherTest'(40 tests passed)./gradlew detektNo tests were ignored.
Screenshots
Not applicable; this fixes selection state synchronization without changing UI layout.
Changelog
Not applicable; Checkout Session is a preview API.
Committed and created by Codex.