Skip to content

fix: allow underscores and mixed-case PaymentSheet font names on android - #2573

Open
iM-GeeKy wants to merge 2 commits into
stripe:masterfrom
iM-GeeKy:fix/android-payment-sheet-fonts
Open

fix: allow underscores and mixed-case PaymentSheet font names on android#2573
iM-GeeKy wants to merge 2 commits into
stripe:masterfrom
iM-GeeKy:fix/android-payment-sheet-fonts

Conversation

@iM-GeeKy

@iM-GeeKy iM-GeeKy commented Aug 16, 2026

Copy link
Copy Markdown

Summary

  • Relaxed Android Payment Sheet font-name validation so res/font filenames can include underscores and mixed-case letters (for example Inter_Bold, Nunito_400Regular, other google fonts), instead of only lowercase alphanumeric characters.
  • Updated the thrown error and TypeScript docs to match the new allowed characters

Motivation

Testing

  • I tested this manually
  • I added automated tests

Documentation

Select one:

  • I have added relevant documentation for my changes.
  • This PR does not result in any developer-facing changes.

@iM-GeeKy
iM-GeeKy requested review from a team as code owners August 16, 2026 10:51
@cla-assistant

cla-assistant Bot commented Aug 16, 2026

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@cla-assistant

cla-assistant Bot commented Aug 16, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@iM-GeeKy

Copy link
Copy Markdown
Author

@porter-stripe Would you or another team member mind taking a look at this? It would be much appreciated. I tagged you as you were one of the ones to last update the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Android custom fonts with expo Font names with underscores incorrectly throw an error on Android in PaymentSheet

1 participant