Create Checkout controllers and session snapshots - #2584
Open
porter-stripe wants to merge 4 commits into
Open
Conversation
porter-stripe
commented
Aug 25, 2026
Comment on lines
+57
to
+60
| // TODO(porter): Uncomment when the reviewed native line item ships. | ||
| // putMap("unitAmountDecimal", amount(lineItem.unitAmountDecimal, session.currency)) | ||
| // putString("unitLabel", lineItem.unitLabel) | ||
| // putMap("adjustableQuantity", serializeAdjustableQuantity(lineItem.adjustableQuantity)) |
Collaborator
Author
There was a problem hiding this comment.
Android hasn't yet added some properties that are flagged with TODOs.
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
porter-stripe
force-pushed
the
porter/checkout-controller-creation
branch
from
August 25, 2026 16:39
4026a56 to
857de91
Compare
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
porter-stripe
marked this pull request as ready for review
August 25, 2026 17:25
…pping' into codex/pr2584-business-logic-cleanup
Committed-By-Agent: codex Co-authored-by: codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Creates Checkout controllers on iOS and Android and returns a stable imperative JavaScript controller backed by ordered session snapshots. Controllers stop emitting after destruction and clean up during explicit destruction or module invalidation. Reviewed fields missing from the pinned native SDKs are left as TODOs until those APIs ship.
Motivation
CheckoutSessions
Testing
Documentation