Repository navigation
[sophora-youtube-connector] Add ServiceMonitor - #308
Open
boossubshell wants to merge 5 commits into
Open
boossubshell wants to merge 5 commits into
boossubshell wants to merge 5 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The changelog incorrectly attributes this feature to version 1.5.0 instead of 1.9.4.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds optional Prometheus ServiceMonitor support to the Sophora YouTube Connector chart.
Changes:
- Adds configurable ServiceMonitor values and template.
- Enables ServiceMonitor rendering in test values.
- Bumps the chart version and updates release metadata.
| File | Description |
|---|---|
Chart.yaml |
Bumps chart version and release annotation. |
CHANGELOG.md |
Documents ServiceMonitor support. |
values.yaml |
Adds ServiceMonitor defaults. |
test-values.yaml |
Enables ServiceMonitor test rendering. |
templates/servicemonitor.yaml |
Defines the ServiceMonitor resource. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
servicemonitor.yaml, added servicemonitor test
DanielRaapDev
approved these changes
Oct 6, 2026
| - isAPIVersion: | ||
| of: monitoring.coreos.com/v1 | ||
| - contains: | ||
| path: spec.endpoints |
Member
There was a problem hiding this comment.
Ich würde gerne die ganze spec testen, also auch die selector.matchLabels. Aber wenn du keine Zeit dafür hast, ist es so schon gut 👍
Comment on lines
+25
to
+27
| - contains: | ||
| path: spec.endpoints | ||
| content: |
Member
There was a problem hiding this comment.
Suggested change
| - contains: | |
| path: spec.endpoints | |
| content: | |
| - equal: | |
| path: spec.endpoints | |
| value: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.