Repository navigation
Conversation
The existing rhef tests are all figure/remote-data tests. These exercise sunkit_image.radial.rhef on the synthetic test maps already in the suite, covering: return type and shape, auto vs supplied radial_bin_edges, a range of upsilon values (None, float, tuple), the scipy/numpy/none ranking methods, that an unknown method raises NotImplementedError, that filtered values stay within the unit interval, and that a vignette only adds NaNs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #210.
The existing tests for the RHEF filter (sunkit_image.radial.rhef) are all
figure / remote_data tests, so the filter has no coverage when the test suite
is run without network access. This adds non-remote unit tests that run the
filter on the synthetic maps already used elsewhere in test_radial.py.
Covered
return type (sunpy.map.GenericMap) and shape, on both test maps
auto-generated vs explicitly supplied radial_bin_edges
a range of upsilon values: None, a float, and a (low, high) tuple
the scipy, numpy and none ranking methods (their outputs are not
asserted equal, since scipy and numpy can differ on tied values)
an unknown method raises NotImplementedError
filtered (non-fill) values stay within the unit interval, as expected from
radial histogram equalisation
a vignette only adds NaNs relative to the same call without one
Run locally under Python 3.11: the new tests pass and the full non-remote
test_radial.py suite stays green (21 passed).
Not included