Skip to content

fix: Use f-strings in ValueError messages #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BrianPugh merged 1 commit into from
May 12, 2025
Merged

fix: Use f-strings in ValueError messages #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion py360convert/c2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ def c2e(
squeeze = False
cube_faces = cube_dice2list(cubemap)
else:
raise ValueError('Unknown cube_format "{cube_format}".')
raise ValueError(f'Unknown cube_format "{cube_format}".')

cube_faces = np.stack(cube_faces)

Expand Down
4 changes: 2 additions & 2 deletions py360convert/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,9 +548,9 @@ def __call__(self, cube_faces: NDArray[DType]) -> NDArray[DType]:
"""
h, w = cube_faces.shape[-2:]
if h != self._h:
raise ValueError("Input height {h} doesn't match expected height {self._h}.")
raise ValueError(f"Input height {h} doesn't match expected height {self._h}.")
if w != self._w:
raise ValueError("Input width {w} doesn't match expected height {self._w}.")
raise ValueError(f"Input width {w} doesn't match expected height {self._w}.")

if cube_faces.dtype == np.float16:
source_dtype = np.float16
Expand Down