fix(gotrue): do not redirect on the link identity flow - #391
Open
AndrewKahr wants to merge 2 commits into
Open
Conversation
Contributor
|
this fixes the response-side gap I noted in #379, so I would give green light👍 |
Author
|
@fresh55 thanks for the feedback! I've made the requested adjustments. Please let me know if anything else is needed to get this merged. Thanks! |
Contributor
|
LGTM 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR fixes #378
What is the current behavior?
There is an error trying to link an identity through the PKCE flow
What is the new behavior?
Successfully links the identity through the PKCE flow instead of getting stuck on the apikey error.