Skip to content

fix: set a fallback redirectUri for external provider#5165

Merged
jgoux merged 6 commits into
supabase:developfrom
singh-inder:patch-2
May 14, 2026
Merged

fix: set a fallback redirectUri for external provider#5165
jgoux merged 6 commits into
supabase:developfrom
singh-inder:patch-2

Conversation

@singh-inder
Copy link
Copy Markdown
Contributor

@singh-inder singh-inder commented May 4, 2026

What kind of change does this PR introduce?

Fix #5216 regression

What is the current behavior?

After #5092, cli no longer sets a default redirectUri for external providers when not defined in config.toml. Also, config file mentions there will be a default redirectUri set if not provided.

# Overrides the default auth callback URL derived from auth.external_url.
redirect_uri = ""

What is the new behavior?

set default redirectUri to Auth.JwtIssuer/callback if not provided

@singh-inder singh-inder requested a review from a team as a code owner May 4, 2026 22:22
@coveralls
Copy link
Copy Markdown

coveralls commented May 11, 2026

Coverage Report for CI Build 25853445741

Coverage decreased (-0.01%) to 63.744%

Details

  • Coverage decreased (-0.01%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • 9 coverage regressions across 2 files.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

9 previously-covered lines in 2 files lost coverage.

File Lines Losing Coverage Coverage
internal/utils/git.go 5 57.14%
internal/start/start.go 4 64.72%

Coverage Stats

Coverage Status
Relevant Lines: 15680
Covered Lines: 9995
Line Coverage: 63.74%
Coverage Strength: 7.06 hits per line

💛 - Coveralls

@jgoux jgoux enabled auto-merge (squash) May 13, 2026 09:57
@jgoux jgoux merged commit 18eeaff into supabase:develop May 14, 2026
16 of 17 checks passed
@singh-inder singh-inder deleted the patch-2 branch May 14, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OAuth returns 400 'missing redirect URI' in v2.98.2 when redirect_uri is blank (worked in v2.92.0)

4 participants