ci!: use client-id instead of deprecated app-id for app tokens - #116
Merged
Conversation
actions/create-github-app-token deprecated the 'app-id' input in favour of 'client-id', which emitted a warning on every 'Generate token' step (twice per step, once for main and once for post). The release workflow now reads the Supabase Releaser client ID from the new GH_APP_CLIENT_ID repository variable. Client IDs are public app metadata, so a variable is a better fit than a secret. The reusable sync-sdk-compliance workflow drops its optional 'app-id' secret input and requires 'client-id'. Callers pinned to earlier SHAs keep working; callers bumping to this revision must pass 'client-id'.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
QuintinWillison
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace the deprecated
app-idinput ofactions/create-github-app-tokenwithclient-id.release.yml: therelease-pleasejob now reads the Supabase Releaser client ID from a newGH_APP_CLIENT_IDrepository variable (already created) instead ofsecrets.APP_ID.sync-sdk-compliance.yml: drops the optionalapp-idsecret input and makesclient-idrequired.Why
Every
Generate tokenstep logged, twice (once for the main step, once for the post step):The action declares
deprecationMessageonapp-id, so the warning fires whenever the key is present inwith, regardless of value. In the reusable workflow that meant the warning appeared even for callers that only passedclient-id, becauseapp-id: ${{ secrets.app-id }}was still listed.Internally the action does
core.getInput("client-id") || core.getInput("app-id")and passes the result straight through as the JWT issuer, so the two inputs are interchangeable apart from the warning.Client IDs are public app metadata (
GET /apps/supabase-releaser), so a repository variable is a better fit than a secret.Breaking change
sync-sdk-compliance.ymlno longer accepts anapp-idsecret. Callers pinned to earlier SHAs are unaffected. Callers bumping past this revision must passclient-id:supabase/supabase-jsalready passesclient-id.supabase/supabase-flutteris updated in ci: use client-id instead of deprecated app-id for app tokens supabase-flutter#1784.supabase/supabase-swiftstill passesapp-idand is pinned tov1.0.0, so it needs updating before its next bump.Test plan
GH_APP_CLIENT_IDmatches thesupabase-releaserapp that authors the release pull requests.