Skip to content

chore(supabase_lints): enable avoid-unnecessary-nullable return-type & parameters #1429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spydon wants to merge 3 commits into
base: chore/enable-avoid-shadowing
Choose a base branch
from
Open

chore(supabase_lints): enable avoid-unnecessary-nullable return-type & parameters #1429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
510dc9f
chore(supabase_lints): enable avoid-unnecessary-nullable return-type …
spydon Jun 17, 2026
9630d89
Merge branch 'chore/enable-avoid-shadowing' into chore/enable-nullabl…
spydon Jun 17, 2026
a0abfce
Merge branch 'chore/enable-avoid-shadowing' into chore/enable-nullabl…
spydon Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/postgrest/lib/src/raw_postgrest_builder.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ class RawPostgrestBuilder<T, S, R> extends PostgrestBuilder<T, S, R> {
/// Very similar to [_copyWith], but allows changing the generics, therefore [_converter] is omitted
RawPostgrestBuilder<O, P, Q> _copyWithType<O, P, Q>({
Uri? url,
// ignore: avoid-unnecessary-nullable-parameters
Headers? headers,
String? schema,
HttpMethod? method,
Expand Down
2 changes: 1 addition & 1 deletion packages/storage_client/lib/src/fetch.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ class Fetch {
return code >= 200 && code <= 299;
}

MediaType? _parseMediaType(String path) {
MediaType _parseMediaType(String path) {
final mime = lookupMimeType(path);
return MediaType.parse(mime ?? 'application/octet-stream');
}
Expand Down
6 changes: 3 additions & 3 deletions packages/supabase/lib/src/platform_io.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'dart:io';

String? get condPlatform => Platform.operatingSystem;
String get condPlatform => Platform.operatingSystem;

String? get condPlatformVersion => Platform.operatingSystemVersion;
String get condPlatformVersion => Platform.operatingSystemVersion;

String? get condRuntimeVersion => Platform.version.split(' ').first;
String get condRuntimeVersion => Platform.version.split(' ').first;
2 changes: 1 addition & 1 deletion packages/supabase/lib/src/supabase_client.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -289,7 +289,7 @@ class SupabaseClient {
}

GoTrueClient _initSupabaseAuthClient({
bool? autoRefreshToken,
required bool autoRefreshToken,
required GotrueAsyncStorage? gotrueAsyncStorage,
required AuthFlowType authFlowType,
}) {
Expand Down
1 change: 1 addition & 0 deletions packages/supabase_flutter/lib/src/local_storage_stub.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// coverage:ignore-file
bool hasAccessToken(String _) => throw UnimplementedError();

// ignore: avoid-unnecessary-nullable-return-type
String? accessToken(String _) => throw UnimplementedError();

void removePersistedSession(String _) => throw UnimplementedError();
Expand Down
6 changes: 3 additions & 3 deletions packages/supabase_flutter/lib/src/platform_io.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import 'dart:io';

String? get condPlatform => Platform.operatingSystem;
String get condPlatform => Platform.operatingSystem;

String? get condPlatformVersion => Platform.operatingSystemVersion;
String get condPlatformVersion => Platform.operatingSystemVersion;

String? get condRuntimeVersion => Platform.version.split(' ').first;
String get condRuntimeVersion => Platform.version.split(' ').first;
6 changes: 3 additions & 3 deletions packages/supabase_flutter/lib/src/supabase_auth.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ import 'package:url_launcher/url_launcher.dart';
/// - Deep link handling is skipped on web (`kIsWeb`) because the browser
/// handles URL-based redirects directly.
class SupabaseAuth with WidgetsBindingObserver {
static WidgetsBinding? get _widgetsBindingInstance => WidgetsBinding.instance;
static WidgetsBinding get _widgetsBindingInstance => WidgetsBinding.instance;

late LocalStorage _localStorage;

Expand Down Expand Up @@ -115,7 +115,7 @@ class SupabaseAuth with WidgetsBindingObserver {
// ignore: invalid_use_of_internal_member
.notifyAllSubscribers(AuthChangeEvent.initialSession);
}
_widgetsBindingInstance?.addObserver(this);
_widgetsBindingInstance.addObserver(this);

if (options.detectSessionInUri) {
await _startDeeplinkObserver();
Expand Down Expand Up @@ -150,7 +150,7 @@ class SupabaseAuth with WidgetsBindingObserver {
}
_authSubscription?.cancel();
_stopDeeplinkObserver();
_widgetsBindingInstance?.removeObserver(this);
_widgetsBindingInstance.removeObserver(this);
}

@override
Expand Down
2 changes: 0 additions & 2 deletions packages/supabase_lints/lib/analysis_options.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,6 @@ dcm:
avoid-throw-in-catch-block: false
avoid-unassigned-stream-subscriptions: false
avoid-unconditional-break: false
avoid-unnecessary-nullable-parameters: false
avoid-unnecessary-nullable-return-type: false
avoid-unnecessary-reassignment: false
avoid-unsafe-collection-methods: false
avoid-unused-parameters: false
Expand Down
Loading