Skip to content

chore: Add additional path for auth-v1-open-callback#44927

Closed
barrownicholas wants to merge 1 commit intosupabase:masterfrom
barrownicholas:patch-1
Closed

chore: Add additional path for auth-v1-open-callback#44927
barrownicholas wants to merge 1 commit intosupabase:masterfrom
barrownicholas:patch-1

Conversation

@barrownicholas
Copy link
Copy Markdown
Contributor

@barrownicholas barrownicholas commented Apr 16, 2026

I have read the CONTRIBUTING.md file.

YES

What kind of change does this PR introduce?

What is the current behavior?

see supabase/cli#5089

What is the new behavior?

see supabase/cli#5089

Additional context

see supabase/cli#5089

Summary by CodeRabbit

  • Bug Fixes
    • Improved authentication callback handling by enabling additional routing paths to ensure proper request processing.

@barrownicholas barrownicholas requested review from a team as code owners April 16, 2026 04:58
@github-actions
Copy link
Copy Markdown
Contributor

Thanks for contributing to Supabase! ❤️ Our team will review your PR.

A few tips for a smoother review process:

  • If you have a local version of the repo, run pnpm run format to make sure formatting checks pass.
  • Once we've reviewed your PR, please don't trivially merge master (don't click Update branch if there are no merge conflicts to be fixed). This invalidates any pre-merge checks we've run.

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
design-system Error Error Apr 16, 2026 4:59am

Request Review

@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 16, 2026

@barrownicholas is attempting to deploy a commit to the Supabase Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 16, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: b9713fea-5f0d-4842-af45-90c8931afef3

📥 Commits

Reviewing files that changed from the base of the PR and between 71acf22 and 91e8ec6.

📒 Files selected for processing (1)
  • docker/volumes/api/kong.yml

📝 Walkthrough

Walkthrough

Added a new Kong route path /callback to the auth-v1-open-callback service in the Kong configuration. The service now routes both /callback and /auth/v1/callback to the upstream endpoint, while preserving existing path stripping and CORS settings.

Changes

Cohort / File(s) Summary
Kong Route Configuration
docker/volumes/api/kong.yml
Added /callback path to the auth-v1-open-callback service routes, expanding the routing scope alongside the existing /auth/v1/callback path.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A callback path, so small and neat,
Another route for auth's repeat,
/callback hops alongside its twin,
Kong routes the traffic with a grin!

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The PR description is largely incomplete, lacking meaningful detail about the change's purpose, rationale, or impact. It relies entirely on external references without providing substantive information. Expand the description with concrete details about the current behavior, why the change is needed, and what the new behavior achieves. Avoid relying solely on external links.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: Add additional path for auth-v1-open-callback' directly and accurately reflects the main change—adding a new path entry to a Kong route configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@aantti aantti self-assigned this Apr 16, 2026
@aantti aantti added the self-hosted Related to self-hosted Supabase label Apr 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

self-hosted Related to self-hosted Supabase

Projects

Development

Successfully merging this pull request may close these issues.

2 participants