Agent: a crashing long-running daemon must not take down the agent and its running tasks - #123
Merged
Merged
Conversation
…on't kill running tasks
… self-hosted runner
…and daemons_list races
…hy-uptime threshold
…sleep shutdown-safe
…rts it instead of killing the agent
… one bad item doesn't restart the daemon
tonybart1337
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The agent runs several long-running daemons as threads (telemetry, ping, GetNewTask/GetStopTask streams, cleaners) and supervises each task in a child container.
Problem:
an unhandled exception in any one of these daemons propagated up and exited the whole agent process. Docker then restarted the agent, and startup cleanup force-removed every running task container — so a transient error in a non-critical daemon (e.g. a telemetry HTTP 500) killed in-flight training tasks and their checkpoints.
Solution: