Skip to content

Restrict TBI to ignore top 4 bits for Darwin targets. #11982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aemerson wants to merge 1 commit into
base: swift/release/6.3
Choose a base branch
from
+13 −8
Open

Restrict TBI to ignore top 4 bits for Darwin targets. #11982

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion llvm/lib/Target/AArch64/AArch64ISelLowering.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23611,7 +23611,12 @@ static SDValue performPostLD1Combine(SDNode *N,
static bool performTBISimplification(SDValue Addr,
TargetLowering::DAGCombinerInfo &DCI,
SelectionDAG &DAG) {
APInt DemandedMask = APInt::getLowBitsSet(64, 56);
const auto &Subtarget = DAG.getSubtarget<AArch64Subtarget>();
// If MTE is enabled, TBI only applies to the top 4 bits.
// Normal arm64 processes on Darwin may be run with MTE enabled.
unsigned NumIgnoreBits =
Subtarget.hasMTE() || Subtarget.isTargetDarwin() ? 4 : 8;
APInt DemandedMask = APInt::getLowBitsSet(64, 64 - NumIgnoreBits);
KnownBits Known;
TargetLowering::TargetLoweringOpt TLO(DAG, !DCI.isBeforeLegalize(),
!DCI.isBeforeLegalizeOps());
Expand Down
14 changes: 7 additions & 7 deletions llvm/test/CodeGen/AArch64/tbi.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
; TBI-NOT: and x
; NO_TBI: and x
define i32 @ld_and32(i64 %p) {
%and = and i64 %p, 72057594037927935
%and = and i64 %p, 1152921504606846975
%cast = inttoptr i64 %and to ptr
%load = load i32, ptr %cast
ret i32 %load
Expand All @@ -18,7 +18,7 @@ define i32 @ld_and32(i64 %p) {
; TBI-NOT: and x
; NO_TBI: and x
define i32 @ld_and_plus_offset(i64 %p) {
%and = and i64 %p, 72057594037927935
%and = and i64 %p, 1152921504606846975
%cast = inttoptr i64 %and to ptr
%gep = getelementptr i32, ptr %cast, i64 4
%load = load i32, ptr %gep
Expand All @@ -40,7 +40,7 @@ define i32 @ld_and32_wider(i64 %p) {
; TBI-NOT: and x
; NO_TBI: and x
define i64 @ld_and64(i64 %p) {
%and = and i64 %p, 72057594037927935
%and = and i64 %p, 1152921504606846975
%cast = inttoptr i64 %and to ptr
%load = load i64, ptr %cast
ret i64 %load
Expand All @@ -50,7 +50,7 @@ define i64 @ld_and64(i64 %p) {
; TBI-NOT: and x
; NO_TBI: and x
define void @st_and32(i64 %p, i32 %v) {
%and = and i64 %p, 72057594037927935
%and = and i64 %p, 1152921504606846975
%cast = inttoptr i64 %and to ptr
store i32 %v, ptr %cast
ret void
Expand All @@ -62,7 +62,7 @@ define void @st_and32(i64 %p, i32 %v) {
; NO_TBI: and x
define i32 @ld_ro(i64 %a, i64 %b) {
%p = add i64 %a, %b
%and = and i64 %p, 72057594037927935
%and = and i64 %p, 1152921504606846975
%cast = inttoptr i64 %and to ptr
%load = load i32, ptr %cast
ret i32 %load
Expand All @@ -73,7 +73,7 @@ define i32 @ld_ro(i64 %a, i64 %b) {
; TBI-NOT: and x
; NO_TBI: and x
define i32 @ld_ro2(i64 %a, i64 %b) {
%and = and i64 %a, 72057594037927935
%and = and i64 %a, 1152921504606846975
%p = add i64 %and, %b
%cast = inttoptr i64 %p to ptr
%load = load i32, ptr %cast
Expand All @@ -85,7 +85,7 @@ define i32 @ld_ro2(i64 %a, i64 %b) {
; TBI-NOT: and x
; NO_TBI: and x
define i32 @ld_indirect_and(i64 %r1, i64 %r2) {
%and = and i64 %r1, 72057594037927935
%and = and i64 %r1, 1152921504606846975
%p = or i64 %and, %r2
%cast = inttoptr i64 %p to ptr
%load = load i32, ptr %cast
Expand Down