Skip to content

Remove a couple areas where tests where changing cwd (fixes AL2 crashes) #9505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daveinglis merged 1 commit into from
Dec 14, 2025
+2 −3
Merged

Remove a couple areas where tests where changing cwd (fixes AL2 crashes) #9505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/IntegrationTests/BasicTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ private struct BasicTests {
#expect(dealerOutput.filter(\.isPlayingCardSuit).count == 10)

// Verify that the 'git status' is clean after a build.
let gitOutput = try sh("git\(ProcessInfo.exeSuffix)", "status", workingDirectory: packagePath).stdout
let gitOutput = try sh("git\(ProcessInfo.exeSuffix)", "-C", packagePath, "status").stdout
#expect(gitOutput.contains("nothing to commit, working tree clean"))

// Verify that another 'swift build' does nothing.
Expand Down
3 changes: 1 addition & 2 deletions Tests/SwiftPMBuildServerTests/BuildServerTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,7 @@ fileprivate func withSwiftPMBSP(fixtureName: String, body: (Connection, Notifica
bspProcess.standardInput = outPipe
let execPath = SwiftPM.xctestBinaryPath(for: "swift-package").pathString
bspProcess.executableURL = URL(filePath: execPath)
bspProcess.arguments = ["experimental-build-server", "--build-system", "swiftbuild"]
bspProcess.currentDirectoryURL = URL(filePath: fixture.pathString)
bspProcess.arguments = ["--package-path", fixture.pathString, "experimental-build-server", "--build-system", "swiftbuild"]
async let terminationPromise: Void = try await bspProcess.run()
let notificationCollector = NotificationCollectingMessageHandler()
connection.start(receiveHandler: notificationCollector)
Expand Down
Loading