Reject uninstantiable payload classes with NotInstantiableException - #50
Open
nicolas-grekas wants to merge 2 commits into
Open
nicolas-grekas wants to merge 2 commits into
nicolas-grekas wants to merge 2 commits into
Conversation
deepclone_from_array() let object_init_ex() throw its Error for abstract classes, interfaces, traits and enums named in a payload, where deepclone_hydrate() and the polyfill throw NotInstantiableException. The class lookup now throws it, once per class and call. deepclone_hydrate() now words NotInstantiableException messages 'Type "X" is not instantiable.' like deepclone_to_array(), deepclone_from_array(), the polyfill and VarExporter do, instead of 'Class "X" is not instantiable.'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
deepclone_from_array()let the engine throw anErrorfor abstract classes, interfaces, traits and enums named in a payload, whiledeepclone_hydrate()and the polyfill throwDeepClone\NotInstantiableException. It now throws that too, from the class lookup that runs once per class and call, and the README lists these classes in its Errors section.deepclone_hydrate()also words its messagesType "X" is not instantiable.like the other functions, the polyfill and VarExporter do, instead ofClass "X".This builds on #47. The polyfill gets the same rules in symfony/polyfill#703.