Fix/high dpi support#692
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Improves WinDynamicDesktop’s UI behavior on high-DPI displays (per #688) by adjusting WinForms layout for the theme search box and making the SkiaSharp theme preview overlay render in DPI-independent (“logical”) coordinates.
Changes:
- Adjust the theme dialog search box vertical position to better accommodate DPI-inflated textbox height.
- Scale the SkiaSharp preview overlay based on
DeviceDpi, while passing a corresponding logicalSKImageInfoto the overlay renderer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/ThemeDialog.cs | Tweaks search box layout to account for DPI-related textbox height changes. |
| src/Skia/ThemePreviewer.cs | Scales overlay drawing to logical coordinates for consistent sizing on high-DPI displays. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
54
to
+55
| this.searchBox.Width = newWidth; | ||
| this.searchBox.Top += (this.searchBox.Height - 23) / 2; |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #688