feat: add permission case system with required context for write/patc…#3392
Open
jmikedupont2 wants to merge 2 commits into
Open
feat: add permission case system with required context for write/patc…#3392jmikedupont2 wants to merge 2 commits into
jmikedupont2 wants to merge 2 commits into
Conversation
…h operations - Add required context field to FSWrite, FSPatch, FSMultiPatch tool calls LLM must provide a justification for every write/patch/multipatch operation - Introduce PermissionCase struct for judicial-style evidence collection - Show proposed content/diff before TUI permission prompt - Include caller context (explanation) in the case panel - Update tool descriptions JSON schema with context field - Fix nixpkgs lock for required rustc 1.94+ - Update all snapshot tests for new schema
|
mike dupont seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
github-actions
Bot
added
the
type: feature
|
Action required: PR inactive for 5 days. |
github-actions
Bot
added
the
state: inactive
| I see the issue - all these tests are using the old struct-based API with `.default()` and setters. Since we changed to an enum-based design, these tests need to be completely rewritten. Let me replace all the problematic tests: | ||
| ```` | ||
| **Update:** `crates/forge_domain/src/compact/summary.rs` | ||
| **MCP:** `patch` |
Contributor
There was a problem hiding this comment.
This is a regression
Author
There was a problem hiding this comment.
Yes sorry I haven't actually spent any more time on this I only had the most basic stuff working I still use it a little bit do you want me to send you up the new version I have the basic permissions working it's not great though
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…h operations