Repository navigation
tailcat: don't crash the server when a client resets before it's served - #188
Merged
Merged
Conversation
gonet's LocalAddr and RemoteAddr return nil once the connection is no
longer connected. If the client resets a connection right after the
handshake, before netstack calls the OnTCP handler, ExecConnHandler
passed those nil addresses to PeerEnv, whose remote.String() panicked
and took the whole server down with every other connection on it:
panic: runtime error: invalid memory address or nil pointer dereference
tailcat.(*Server).PeerEnv tailcat_exec.go:49
tailcat.(*Server).ExecConnHandler.func1 tailcat_exec.go:29
netstack.(*Impl).acceptTCP
ExecConnHandler now closes such a connection without running the
command, and PeerEnv leaves out an address it doesn't have (an SSH
session's connection can be reset at any time too).
Signed-off-by: Kirill <kirill2003de@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Moved from #167 by @bra1nDump]
gonet's LocalAddr and RemoteAddr return nil once the connection is no
longer connected. If the client resets a connection right after the
handshake, before netstack calls the OnTCP handler, ExecConnHandler
passed those nil addresses to PeerEnv, whose remote.String() panicked
and took the whole server down with every other connection on it:
ExecConnHandler now closes such a connection without running the
command, and PeerEnv leaves out an address it doesn't have (an SSH
session's connection can be reset at any time too).