Repository navigation
tailcat: don't hang an exec connection after the command exits - #189
Merged
Merged
Conversation
runConnCommand waited for both copy goroutines before calling cmd.Wait. The comment claimed the stdin copy would finish on its own once the process was gone, but that only holds if the client sends more data. A client that stays connected without sending anything or half-closing left the stdin copy blocked in c.Read forever, so cmd.Wait never ran, leaking a zombie process, two goroutines and the connection. Now copy stdout in the calling goroutine, wait for the command to exit, and then close the connection to unblock the stdin copy. Stdin is still forwarded concurrently, so interactive commands keep working. Thanks to @CJstate for pointing out the problem in PR #182! Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runConnCommand waited for both copy goroutines before calling
cmd.Wait. The comment claimed the stdin copy would finish on its own
once the process was gone, but that only holds if the client sends
more data. A client that stays connected without sending anything or
half-closing left the stdin copy blocked in c.Read forever, so
cmd.Wait never ran, leaking a zombie process, two goroutines and the
connection.
Now copy stdout in the calling goroutine, wait for the command to
exit, and then close the connection to unblock the stdin copy. Stdin
is still forwarded concurrently, so interactive commands keep working.
Thanks to @CJstate for pointing out the problem in PR #182!