Repository navigation
android: resolve LocalAPI backend through Client - #900
Merged
Merged
Conversation
LocalAPI requests currently rely on a static application reference populated by Request.setApp() during backend initialization. We introduced a lazy init in c56420b to ensure we weren't making LocalAPI calls before initialization, but the property is never accessed, and as a result, requests issued during a cold start can fail before the backend is initialized. This change has Client provide libtailscale to each request instead of relying on global state, making Client responsible for supplying the dependency rather than requiring requests initialize themselves. When each request executes, we get the current libtailscale application instance (or initialize if necessary). Fixes tailscale/tailscale#20884 Signed-off-by: kari-ts <kari@tailscale.com>
This was referenced Oct 22, 2026
hiimtmac
approved these changes
Oct 23, 2026
hiimtmac
left a comment
hiimtmac
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Perhaps in the future we should try and decouple Request from app but that is out of scope of this fix.
barnstar
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LocalAPI requests currently rely on a static application reference populated by Request.setApp() during backend initialization. We introduced a lazy init in c56420b to ensure we weren't making LocalAPI calls before initialization, but the property is never accessed, and as a result, requests issued during a cold start can fail before the backend is initialized.
This change has Client provide libtailscale to each request instead of relying on global state, making Client responsible for supplying the dependency rather than requiring requests initialize themselves. When each request executes, we get the current libtailscale application instance (or initialize if necessary).
Fixes tailscale/tailscale#20884