Repository navigation
ts_netmon: only re-export PlatformMon where it exists - #467
Merged
Merged
Conversation
npry
force-pushed
the
npry/netmon.cherry-pick-export-fix
branch
from
October 29, 2026 00:05
89f76f7 to
e834f25
Compare
PlatformMon is only defined on Linux, macOS and Windows, but lib.rs
re-exported it unconditionally, so ts_netmon (and everything depending
on it) failed to build on other targets such as Android:
error[E0432]: unresolved import `netmon::PlatformMon`
platform_mon() already returns None on those targets, so gating the
re-export is enough for the runtime to build and run without a
platform network monitor.
Verified with cargo check and clippy for aarch64-linux-android,
x86_64-linux-android and armv7-linux-androideabi.
Signed-off-by: Jesus S Flores <jesus14sf@gmail.com>
npry
force-pushed
the
npry/netmon.cherry-pick-export-fix
branch
from
October 29, 2026 00:21
e834f25 to
2c67f76
Compare
nrc
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick from comments of #443 -- export fixup for netmon for non-{windows,mac,linux} targets
Updates #443