Repository navigation
Conversation
Add TcpStream::shutdown to close only the sending half of a connection. Drop blocked commands whose requester has gone away rather than completing them and discarding the result. Signed-off-by: Nick Cameron <nrc@ncameron.org>
npry
reviewed
Nov 5, 2026
npry
left a comment
Member
There was a problem hiding this comment.
The cancellation piece is a dup of #466, hence the conflicts.
We actually need a fix here, which I think is to make the current Close command .abort() the socket rather than .close() (since .close() is really half-close) and yeah, I agree with calling it shutdown since it's the same API as std/tokio TcpStream. I think it probably makes sense to do those simultaneously, but I'd want some actual network tests proving correct behavior. If you don't want to dive into that we might want to have me or dylan take it -- let's chat at sync
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add TcpStream::shutdown to close only the sending half of a connection. Drop blocked commands whose requester has gone away rather than completing them and discarding the result.
Extracted from #462
AI decl: basically vibe-coded. I've tried to review but I don't have enough context to know if this is the right approach or that it works properly.
cc @npry