Repository navigation
Conversation
Signed-off-by: Nick Cameron <nrc@ncameron.org>
npry
reviewed
Nov 4, 2026
Member
There was a problem hiding this comment.
I held off on this one (my branch with similar diff) because this actually breaks due to how kameo handles linked actors. Iirc, not panicking will cause the uniderp runner task to never restart itself, while the panic looks worse because it prints in process stdout, but it actually does the right thing (because kameo only restarts links on error I think? so the panic causes the supervision logic to restart it, while the caught error means it exits normally and isn't restarted).
It's definitely the right thing to do in ts_derp to produce an error rather than panicking if we don't have servers, but ts_runtime needs some adjustment as well to make this work properly
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a side-effect, adds a new error for when we can't find a derp server. This is expected to happen if the runtime has been shutdown, but presumably could happen for other reasons too.
These panics turned up when testing the node.js bindings (#462) and this PR is extracted from that one.
AI decl: Claude did this to fix some failing tests. I've reviewed and edited, but I don't know if this is the correct approach.
cc @npry