Repository navigation
Conversation
npry
requested review from
danderson,
dylan-tailscale and
nrc
as code owners
November 17, 2026 19:40
npry
force-pushed
the
npry/rt.statefile-perms
branch
2 times, most recently
from
November 17, 2026 21:24
be21327 to
6a6a596
Compare
This is a unix-only fix which sets the permission bits to 0600 by default and emits a `tracing::warn!` if they're otherwise configured on an existing file. Implements basic tests for config file loading as well, including one which verifies this permission behavior on unix platforms. Closes #449 Signed-off-by: Nathan Perry <nathan@tailscale.com> Change-Id: Ieb06fd8ca92ddbcf37379311c7449ba06a6a6964
npry
force-pushed
the
npry/rt.statefile-perms
branch
from
November 17, 2026 21:24
6a6a596 to
fefe658
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a unix-only fix which sets the permission bits to 0600 by default and emits a
tracing::warn!if they're otherwise configured on an existing file.Implements basic tests for config file loading as well, including one which verifies this permission behavior on unix platforms.
Closes #449