[import-defer] adding new test cases to validate evaluation trigger #4621
+622
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiolima
force-pushed
the
import-defer-new-cases
branch
from
9eb62cf to
c32db76
Compare
| Marker.mark(ns); | ||
| }); | ||
|
|
||
| assert.sameValue(globalThis.evaluations.length, 0, "It does not trigger evaluation"); |
Member
There was a problem hiding this comment.
Can we also check that #mark in ns does not trigger evaluation?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding cases when namespace object is in the prototype chain go another object for
[[Get]]and[[HasProperty]]. It also adds a case that validates that Private Names installation, set and get don't trigger deferred modules evaluation.