Skip to content

fix jexl transformation expression when is a JSON based value#863

Merged
mrutid merged 5 commits into
masterfrom
fix/jexl_parser_json_value_attr
May 7, 2020
Merged

fix jexl transformation expression when is a JSON based value#863
mrutid merged 5 commits into
masterfrom
fix/jexl_parser_json_value_attr

Conversation

@AlvaroVega

@AlvaroVega AlvaroVega commented May 6, 2020

Copy link
Copy Markdown
Member

bug in previos PR #861 by @chicco785
to avoid json expression will be transformed to [object Object]

{
            "name" : "mylocation",
            "type" : "geo:json",
            "expression" : "{type: \"Point\", coordinates: [lat,lon]}"
        }

No CNR update is needed since is reopen a previous PR

@AlvaroVega AlvaroVega changed the title [WIP] fix jexl paser when a json value attr fix jexl paser when a json value attr May 7, 2020
@AlvaroVega AlvaroVega requested a review from fgalan May 7, 2020 07:28
@AlvaroVega AlvaroVega changed the title fix jexl paser when a json value attr fix jexl transformation expression when is a JSON based value May 7, 2020

@mrutid mrutid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Improve Json management is debt.

@mrutid mrutid merged commit 9f8af4f into master May 7, 2020
@mrutid mrutid deleted the fix/jexl_parser_json_value_attr branch May 7, 2020 07:56
@chicco785

Copy link
Copy Markdown
Contributor

i think it may be good to add this in the test and examples

@fgalan

fgalan commented May 7, 2020

Copy link
Copy Markdown
Member

i think it may be good to add this in the test and examples

Sound goods. Maybe you could help providing such contribution? We can focus our resources in fix some flaws of your original implementation, but for things like those your contribution would be very welcomed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants