feat(database): add option to get underlaying query for property relation#2102
Open
laylatichy wants to merge 29 commits intotempestphp:3.xfrom
Open
feat(database): add option to get underlaying query for property relation#2102laylatichy wants to merge 29 commits intotempestphp:3.xfrom
laylatichy wants to merge 29 commits intotempestphp:3.xfrom
Conversation
…cit attr, unsaved model, nonexistent property, empty result)
…getHasManyThrough/getBelongsToMany calls
…ead of manual property check
…e, return QueryBuilder for select/update/delete support
…s all relation types
…longsToMany query()
…pe for subquery relations
Benchmark ResultsComparison of Open to see the benchmark results
Generated by phpbench against commit ceec41c |
…r BelongsToMany delete support
…e query() for relations
… a public instance method
6ca7341 to
6f7d0ff
Compare
… instead of duplicating pivot logic
debbc8f to
ceec41c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pr to add option to have similar behavior to laravels author->books() to get underlying query for property relation we can chain into
works with all relation types:
now, I wasnt sure about naming it but opted in for
querysince it returns querybuilder same as query() helper just scoped to model property